> item 3:
> There are several routines in the DC package which are obsolete because
> (i) parameters are now read from map files - not BOS files,
> (ii) there are several choices for x(t) relations that are obsolete.
> Moreover, as all the code in dc/ is also used in trk/ we decide not only
> to clean up the dc/ and trk/ code but move the remaining dc/ routines
> into the trk/ package.
>
> Common blocks should only be used within a single package.
> The 'Makefile' scheme should be changed to search for include/header files
> only in the package itself and the include/ package.
>
> Franz, Joe, and Liming will clean up the code.
>
> ===============================================================
> Franz J. Klein, Thomas Jefferson National Accelerator Facility,
> 12000 Jefferson Avenue MS 12H, Newport News, VA 23606
> Email: fklein@jlab.org, Tel: (757)269-5879, Fax: (757)269-5800
> ---------------------------------------------------------------
Sorry for getting into the conversation late, but....
I disagree about combining the dc and trk packages -- especially since we
want to use the same geometry and x<->t functions for GSIM and RECSIS, and
I don't think we want to have to include the tracking package when we
build GSIM. Modularity is a good thing.
What things are we using from dc common blocks? Doing a quick look through
the code, I see:
dc_sigma_doca that we probably will eventually want to change
a bit faster than by simply superlayer -- should be
in DCGM bos bank for each layer?
this is also used in a function that does an x<->t
calculation. Why not put the function (or at least
the conversion) into the dc package?
(culprits: ana_docam.F, trk_dtime.F, trk_dcam.F(why?),
ana_trfit.F (why?))
dc_xvst_choice Also used by functions in the trk package that
decide how to do the x<->t relation. The way I see
that we want to handle this is to call a dc package
routine with a drift time and whatever parameters
(wire,layer,alpha?) we need for that point, and then
have the dc routine return the appropriate calcdoca and
sigmadoca for that hit.
(trk_dtime.F)
t0, DC_Tslope going from raw TDC to drift time, include TOF offset.
(trk_dtime.F, ana_prfit.F)
dc_trig_time modify start time. (trk_dcam.F)
It appears that alot of the trk functions that include dc common blocks
do so to do a t->x calculation (ana_docam.F, trk_dtime.F) or modify the
time for timing delays (ana_prfit.F,trk_dcam.F). And a few include dc
common blocks for reasons that I cannot figure out (trk_evnt_hbt.F,
trk_brun.F, in ana_trfit.F it is obsolete as far as I can tell).
I propose that instead of combining the trk and dc packages, we put the
stuff that deals with the drift chambers -- namely x->t function calls --
back into the dc package.
Thanks for listening,
Rob